Repository navigation
fix: expose stderr and returncode from _run_stream via _last_stream_r… - #17
Open
uchime1234 wants to merge 1 commit into
Open
uchime1234 wants to merge 1 commit into
uchime1234 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stores a
CommandResultsinstance onself._last_stream_resultafter_run_streamfinishes, mirroring the existing pattern in_run.Problem
Closes #11 —
_run_streamcaptured stderr and returncode viasubprocess.PIPEbut silently discarded them, making terraform diagnostics unavailable to callers and subclasses (e.g. Celery workers that need to logTF_LOGoutput).Changes
self._last_stream_result = Nonein__init__.self._last_stream_resultwith aCommandResultsin_run_stream.Tofuclass docstring to document the new attribute.tests/test_stream_results.pycovering plan, apply, error-module, and repeat-run cases.Testing
python -m pytest --cov=./tofupy --cov-report=term-missing testspython -m ruff checkpython -m ruff format . --checkpython -m mypy tofupyAll pass locally on Windows with OpenTofu 1.9.0.