Repository navigation
Conversation
PhuocOng
marked this pull request as ready for review
September 24, 2026 17:40
PhuocOng
requested review from
jmeridth,
tico24 and
yu-croco
as code owners
September 24, 2026 17:40
tico24
previously approved these changes
Sep 29, 2026
tico24
force-pushed
the
fix/rollouts-servicemonitor-namespace
branch
from
October 14, 2026 07:36
d86229f to
3826328
Compare
tico24
previously approved these changes
Oct 14, 2026
tico24
enabled auto-merge (squash)
October 14, 2026 07:40
Signed-off-by: Peter Ong <peterong@microsoft.com>
tico24
force-pushed
the
fix/rollouts-servicemonitor-namespace
branch
from
October 26, 2026 09:08
3826328 to
4181b1a
Compare
tico24
previously approved these changes
Oct 26, 2026
argo-helm now bumps chart versions after merge (argoproj#4176). This puts the version and artifacthub.io/changes in Chart.yaml back to main's, and moves this PR's changelog entry into charts/argo-rollouts/changes/honor-namespaceoverride-in-servicemonitor.yaml with the same bump level. Signed-off-by: Tim Collins <tim@thecollins.team>
tico24
approved these changes
Oct 29, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4094.
The metrics Service uses the
argo-rollouts.namespacehelper, but the ServiceMonitor target selector uses.Release.Namespace. WhennamespaceOverridediffers from the release namespace, the monitor cannot select the Service it is meant to scrape.Use the same namespace helper for
spec.namespaceSelector.matchNames. The monitor's own configurable namespace, labels and endpoint port are unchanged. No new values, images or dependencies.Validation (Helm 4.2.3, chart-testing 3.14.0, kind / Kubernetes 1.35.0):
namespaceOverrideand with/without a separate monitor namespace. Both override cases fail before the fix; all four pass afterward, including matching Service labels and ports.Upstream Linting and Testing passed on commit
d86229fd09153b380a1d6411f22b6fab58d01fb5, including all three install configurations. All seven PR checks passed.Prepared with GitHub Copilot assistance.
Checklist: