[imansabet]

Fixes #4092

The controller and admission webhook PodDisruptionBudget templates used a plain truthiness check on minAvailable / maxUnavailable. Since 0 is falsy in Go templates, maxUnavailable: 0 fell through to the default branch and rendered minAvailable: 0, which does not block voluntary evictions.

This switches both templates to not (kindIs "invalid" ...), the same pattern already used in the argo-workflows PDB templates, so an explicit 0 is honored while unset values keep the current default.

Tested with helm template for the controller and the webhook:

• maxUnavailable=0 renders maxUnavailable: 0 (was minAvailable: 0)
• minAvailable=1 renders minAvailable: 1
• nothing set renders minAvailable: 0 (unchanged)
• maxUnavailable=1 renders maxUnavailable: 1

I also compared the full rendered output before and after the change. The only differences are the chart version label, the config checksum (derived from a ConfigMap that carries the chart version label), and the two PDBs.

Checklist:

• I have bumped the chart version according to versioning
• I have updated the documentation according to documentation
• I have updated the chart changelog with all the changes that come with this pull request according to changelog.
• I wrote this PR with the help of a LLM but I fully vetted the work before raising this PR for review
• Any new values are backwards compatible and/or have sensible default.
• I have signed off all my commits as required by DCO.
• I have created a separate pull request for each chart according to pull requests
• My build is green (troubleshooting builds).

[tico24]

There's already #4093 open for #4092, and I've asked for this same kindIs "invalid" change on it. I'd like to give that author the chance to push it first, so I'm holding off on this one for now.

[imansabet]

There's already #4093 open for #4092, and I've asked for this same kindIs "invalid" change on it. I'd like to give that author the chance to push it first, so I'm holding off on this one for now.

thanks for letting me know. I missed #4093 when I started on this.