Repository navigation
fix(argo-cd): Reset Redis sentinel over TLS - #4167
Draft
tlauder-jobber wants to merge 5 commits into
Draft
tlauder-jobber wants to merge 5 commits into
tlauder-jobber wants to merge 5 commits into
Conversation
Signed-off-by: Trevor Lauder <trevor.l@getjobber.com>
Signed-off-by: Trevor Lauder <trevor.l@getjobber.com>
tlauder-jobber
marked this pull request as ready for review
October 24, 2026 00:11
tlauder-jobber
requested review from
jmeridth,
mbevc1,
mkilchhofer,
tico24 and
yu-croco
as code owners
October 24, 2026 00:11
Co-authored-by: Tim Collins <45351296+tico24@users.noreply.github.com> Signed-off-by: Trevor Lauder <trevor.l@getjobber.com>
Signed-off-by: Trevor Lauder <trevor.l@getjobber.com>
argo-helm now bumps chart versions after merge (argoproj#4176). This puts the version and artifacthub.io/changes in Chart.yaml back to main's, and moves this PR's changelog entry into charts/argo-cd/changes/reset-redis-sentinel-over-tls.yaml with the same bump level. Signed-off-by: Tim Collins <tim@thecollins.team>
4 of 8 tasks
jmeridth
marked this pull request as draft
November 1, 2026 01:58
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sentinel reset hook from #4026 fails when sentinel is TLS-only, which crash-loops sentinel. It now reads sentinel's config to connect with or without TLS. A new CI values file covers TLS-only sentinel.
Checklist: