Repository navigation
Conversation
HTTPRoute hostnames are optional and are inherited from the attached listener. Deriving them from global.domain broke routes when custom listeners were used (non-overlapping hostname) or global.domain was empty. Also omit the auto-derived sectionName when custom listeners are provided. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: Raul Garcia Sanchez <info@raulgarcia.de>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: Raul Garcia Sanchez <info@raulgarcia.de>
rgarcia89
requested review from
jmeridth,
mbevc1,
mkilchhofer,
tico24 and
yu-croco
as code owners
October 30, 2026 14:41
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: Raul Garcia Sanchez <info@raulgarcia.de>
tico24
reviewed
Oct 31, 2026
…stenerName Address review feedback: only drop the auto-derived sectionName when none of the custom listeners is named listenerName, and bump the change to minor since wildcard listeners now match all their hosts. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: Raul Garcia Sanchez <info@raulgarcia.de>
Author
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HTTPRoute hostnames are optional and are inherited from the attached listener. Deriving them from global.domain broke routes when custom listeners were used (non-overlapping hostname) or global.domain was empty. Also omit the auto-derived sectionName when custom listeners are provided.
Applies to both the
serverandapplicationSetHTTPRoutes. Before this change, enablinglistenersetwith an emptyhttproute.hostnamesrenderedhostnames: [<global.domain>], even whenlistenerset.listenersdefined a different hostname, or[""]whenglobal.domainwas empty. Nowhostnamesis only rendered when set explicitly. I also corrected the ListenerSet comments invalues.yamlfromv1alpha2to Gateway API v1.5+, to match the README and the templates.Added
ci/listenerset-httproute-custom-listeners-values.yamlto cover custom listeners together with an HTTPRoute.Checklist:
bumpaccording to versioning